libtransport.git Changeset - 08a5e487db0c

Changeset - 08a5e487db0c

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Jan Kaluza - 13 years ago 2012-11-27 10:33:04
hanzz.k@gmail.com

Better error message when backends can't be started

2 files changed with 9 insertions and 2 deletions:

backends/twitter/main.cpp

src/networkpluginserver.cpp

0 comments (0 inline, 0 general)

backends/twitter/main.cpp

➞

Show inline comments

@@ @@ -36,13 +36,14 @@ int main (int argc, char* argv[]) { @@
 	Logging::initBackendLogging(cfg);
 	StorageBackend *storagebackend;
 	storagebackend = StorageBackend::createBackend(cfg, error);
 	if (storagebackend == NULL) {
 		LOG4CXX_ERROR(logger, "Error creating StorageBackend! " << error)
 		LOG4CXX_ERROR(logger, "Error creating StorageBackend! " << error);
 		LOG4CXX_ERROR(logger, "Twitter backend needs storage backend configured to work! " << error);
 		return -2;
+	}
 	else if (!storagebackend->connect()) {
 		LOG4CXX_ERROR(logger, "Can't connect to database!")
 		return -1;

src/networkpluginserver.cpp

➞

Show inline comments

@@ @@ -329,13 +329,19 @@ void NetworkPluginServer::start() { @@
 		pid_t result;
 		int status;
 		result = waitpid(-1, &status, WNOHANG);
 		if (result != 0) {
 			if (WIFEXITED(status)) {
 				if (WEXITSTATUS(status) != 0) {
 					LOG4CXX_ERROR(logger, "Backend can not be started, exit_code=" << WEXITSTATUS(status) << ", possible error: " << strerror(WEXITSTATUS(status)));
 					if (status == 254) {
 						LOG4CXX_ERROR(logger, "Backend can not be started, because it needs database to store data, but the database backend is not configured.");
+					}
 					else {
 						LOG4CXX_ERROR(logger, "Backend can not be started, exit_code=" << WEXITSTATUS(status) << ", possible error: " << strerror(WEXITSTATUS(status)));
+					}
 					LOG4CXX_ERROR(logger, "Check backend log for more details");
 					continue;
+				}
+			}
 			else {
 				LOG4CXX_ERROR(logger, "Backend can not be started");
 				continue;

0 comments (0 inline, 0 general)