libtransport.git Changeset - 88f6ecb38291

Changeset - 88f6ecb38291

Parent rev.

Child rev.

[Not reviewed]

0 1 0

HanzZ - 14 years ago 2011-07-31 09:19:47
hanzz.k@gmail.com

remove buddy icon unrefing, just to test if it's the reason why libpurple crashes

1 file changed with 4 insertions and 4 deletions:

backends/libpurple/main.cpp

0 comments (0 inline, 0 general)

backends/libpurple/main.cpp

➞

Show inline comments

@@ @@ -584,7 +584,7 @@ static std::string getIconHash(PurpleBuddy *m_buddy) { @@
 	PurpleBuddyIcon *icon = purple_buddy_icons_find(purple_buddy_get_account(m_buddy), purple_buddy_get_name(m_buddy));
 	if (icon) {
 		avatarHash = purple_buddy_icon_get_full_path(icon);
 		purple_buddy_icon_unref(icon);
+// 		purple_buddy_icon_unref(icon);
+	}
 	if (avatarHash) {
@@ @@ -614,7 +614,7 @@ static std::string getIconHash(PurpleBuddy *m_buddy) { @@
 static std::vector<std::string> getGroups(PurpleBuddy *m_buddy) {
 	std::vector<std::string> groups;
 	groups.push_back(purple_group_get_name(purple_buddy_get_group(m_buddy)) ? std::string(purple_group_get_name(purple_buddy_get_group(m_buddy))) : std::string("Buddies"));
+	groups.push_back((purple_buddy_get_group(m_buddy) && purple_group_get_name(purple_buddy_get_group(m_buddy))) ? std::string(purple_group_get_name(purple_buddy_get_group(m_buddy))) : std::string("Buddies"));
 	return groups;
+}
 			if (len < 300000 && data) {
 				photo = Swift::createByteArray(data, len);
+			}
 			purple_imgstore_unref(avatar);
+// 			purple_imgstore_unref(avatar);
+		}
+	}
 // 					}
 // 				}
+			}
 			purple_buddy_icon_unref(icon);
+// 			purple_buddy_icon_unref(icon);
+		}
+	}

0 comments (0 inline, 0 general)