libtransport.git Changeset - cb26fb025845

Changeset - cb26fb025845

Parent rev.

Child rev.

[Not reviewed]

0 1 0

Jan Kaluza - 9 years ago 2016-02-21 20:10:28
jkaluza@redhat.com

Libpurple: Show more error messages when something goes wrong during PURPLE_IMAGE handling

1 file changed with 8 insertions and 1 deletions:

backends/libpurple/main.cpp

0 comments (0 inline, 0 general)

backends/libpurple/main.cpp

➞

Show inline comments

 			std::string name;
 			guchar * data = (guchar *) purple_imgstore_get_data_wrapped(image);
 			size_t len = purple_imgstore_get_size_wrapped(image);
-			if (len < 300000 && data) {
+			if (len < 1000000 && data) {
 				ext = purple_imgstore_get_extension(image);
 				char *hash = calculate_data_hash(data, len, "sha1");
 				if (!hash) {
 					LOG4CXX_WARN(logger, "Cannot compute hash for the image.");
 					return;
+				}
 				name = hash;
 				g_free(hash);
 				std::ofstream output;
 				LOG4CXX_INFO(logger, "Storing image to " << std::string(CONFIG_STRING(config, "service.web_directory") + "/" + name + "." + ext));
 				output.open(std::string(CONFIG_STRING(config, "service.web_directory") + "/" + name + "." + ext).c_str(), std::ios::out | std::ios::binary);
 				if (output.fail()) {
 					LOG4CXX_ERROR(logger, "Open file failure: " << strerror(errno));
 					return;
+				}
 				output.write((char *)data, len);
 				output.close();
+			}
 			else {
 				LOG4CXX_WARN(logger, "Image bigger than 1MB.");
 				purple_imgstore_unref_wrapped(image);
 				return;
+			}

0 comments (0 inline, 0 general)