libtransport.git Changeset - fe74083e2e3c

Changeset - fe74083e2e3c

Parent rev.

Child rev.

[Not reviewed]

0 2 0

HanzZ - 14 years ago 2011-12-10 15:44:43
hanzz.k@gmail.com

Do not try to serialize something what is not Storage element

2 files changed with 16 insertions and 6 deletions:

include/transport/pqxxbackend.h

src/storageresponder.cpp

0 comments (0 inline, 0 general)

include/transport/pqxxbackend.h

➞

Show inline comments

@@ @@ -18,25 +18,25 @@ @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02111-1301  USA
  */
 #pragma once
 #ifdef WITH_PQXX
 #include <string>
 #include <map>
 #include "Swiften/Swiften.h"
 #include "transport/storagebackend.h"
 #include "transport/config.h"
-#include "mysql.h"
+#include <pqxx/pqxx>
 namespace Transport {
 /// Used to store transport data into SQLite3 database.
 class PQXXBackend : public StorageBackend
+{
 	public:
 		/// Creates new PQXXBackend instance.
 		/// \param config cofiguration, this class uses following Config values:
 		/// 	- database.database - path to SQLite3 database file, database file is created automatically
 		/// 	- service.prefix - prefix for tables created by createDatabase method
 		PQXXBackend(Config *config);
@@ @@ -90,17 +90,19 @@ class PQXXBackend : public StorageBackend @@
 		void removeBuddy(long id) {}
 		void getUserSetting(long userId, const std::string &variable, int &type, std::string &value);
 		void updateUserSetting(long userId, const std::string &variable, const std::string &value);
 		void beginTransaction();
 		void commitTransaction();
 	private:
 		bool exec(const std::string &query);
 		Config *m_config;
 		std::string m_prefix;
 		pqxx::connection *m_conn;
 };
+}
 #endif

src/storageresponder.cpp

➞

Show inline comments

 	sendResponse(from, id, boost::shared_ptr<PrivateStorage>(new PrivateStorage(boost::shared_ptr<RawXMLPayload>(new RawXMLPayload(value)))));
 	return true;
+}
 bool StorageResponder::handleSetRequest(const Swift::JID& from, const Swift::JID& to, const std::string& id, boost::shared_ptr<Swift::PrivateStorage> payload) {
 	User *user = m_userManager->getUser(from.toBare().toString());
 	if (!user) {
 		sendError(from, id, ErrorPayload::NotAcceptable, ErrorPayload::Cancel);
 		LOG4CXX_WARN(logger, from.toBare().toString() << ": User is not logged in");
 		return true;
+	}
 	StorageSerializer serializer;
 	std::string value = serializer.serializePayload(boost::dynamic_pointer_cast<Storage>(payload->getPayload()));
 	m_storageBackend->updateUserSetting(user->getUserInfo().id, "storage", value);
 	LOG4CXX_INFO(logger, from.toBare().toString() << ": Storing jabber:iq:storage");
 	sendResponse(from, id, boost::shared_ptr<PrivateStorage>());
 	boost::shared_ptr<Storage> storage = boost::dynamic_pointer_cast<Storage>(payload->getPayload());
 	if (storage) {
 		StorageSerializer serializer;
 		std::string value = serializer.serializePayload(boost::dynamic_pointer_cast<Storage>(payload->getPayload()));
 		m_storageBackend->updateUserSetting(user->getUserInfo().id, "storage", value);
 		LOG4CXX_INFO(logger, from.toBare().toString() << ": Storing jabber:iq:storage");
 		sendResponse(from, id, boost::shared_ptr<PrivateStorage>());
+	}
 	else {
 		LOG4CXX_INFO(logger, from.toBare().toString() << ": Unknown element. Libtransport does not support serialization of this.");
 		sendError(from, id, ErrorPayload::NotAcceptable, ErrorPayload::Cancel);
+	}
 	return true;
+}
+}

0 comments (0 inline, 0 general)