Files
@ f328e80a974a
Branch filter:
Location: libtransport.git/libtransport/AdminInterfaceCommand.cpp
f328e80a974a
3.5 KiB
text/x-c++hdr
Fix possible double free in ThreadPool
This makes HTTPRequestTest::GETThreadPool test pass deterministicaly.
Problem was static slot used to cleanup threads. When ThreadPool was instantiated
multiple times, threads were also clened up multiple times resulting in segfault.
This makes HTTPRequestTest::GETThreadPool test pass deterministicaly.
Problem was static slot used to cleanup threads. When ThreadPool was instantiated
multiple times, threads were also clened up multiple times resulting in segfault.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 | /**
* libtransport -- C++ library for easy XMPP Transports development
*
* Copyright (C) 2011, Jan Kaluza <hanzz.k@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
*/
#include "transport/AdminInterfaceCommand.h"
#include "transport/User.h"
#include <boost/foreach.hpp>
#include <boost/lexical_cast.hpp>
#include <iostream>
#include <Swiften/Version.h>
#define HAVE_SWIFTEN_3 (SWIFTEN_VERSION >= 0x030000)
namespace Transport {
AdminInterfaceCommand::AdminInterfaceCommand(const std::string &name, Category category, Context context, AccessMode accessMode, Actions actions, const std::string &label) {
m_name = name;
m_category = category;
m_context = context;
m_accessMode = accessMode;
m_actions = actions;
m_label = label;
}
const std::string AdminInterfaceCommand::getCategoryName(Category category) {
switch (category) {
case AdminInterfaceCommand::General:
return "General";
case AdminInterfaceCommand::Users:
return "Users";
case AdminInterfaceCommand::Messages:
return "Messages";
case AdminInterfaceCommand::Frontend:
return "Frontend";
case AdminInterfaceCommand::Backends:
return "Backends";
case AdminInterfaceCommand::Memory:
return "Memory";
default:
return "Unknown";
}
}
std::string AdminInterfaceCommand::handleSetRequest(UserInfo &uinfo, User *user, std::vector<std::string> &args) {
if ((m_actions & Set) == 0) {
return "Error: This variable cannot be set.";
}
if (user && (m_accessMode & AdminMode) != 0) {
return "Error: You do not have rights to set this variable.";
}
if ((!user && uinfo.id == -1) && (m_context & UserContext)) {
return "Error: This variable can be set only in user context.";
}
if (args.empty()) {
return "Error: Value is missing.";
}
return "";
}
std::string AdminInterfaceCommand::handleGetRequest(UserInfo &uinfo, User *user, std::vector<std::string> &args) {
if ((m_actions & Get) == 0) {
return "Error: This variable cannot be get.";
}
if (user && (m_accessMode & AdminMode) != 0) {
return "Error: You do not have rights to get this variable.";
}
if ((!user && uinfo.id == -1) && (m_context & UserContext)) {
return "Error: This variable can be get only in user context.";
}
return "";
}
std::string AdminInterfaceCommand::handleExecuteRequest(UserInfo &uinfo, User *user, std::vector<std::string> &args) {
if ((m_actions & Execute) == 0) {
return "Error: This is not a command, but a variable.";
}
if (user && (m_accessMode & AdminMode) != 0) {
return "Error: You do not have rights to execute this command.";
}
if ((!user && uinfo.id == -1) && (m_context & UserContext)) {
return "Error: This command can be executed only in user context.";
}
if (m_args.size() > args.size()) {
return "Error: Argument is missing.";
}
if (m_args.size() < args.size()) {
return "Error: Too many arguments.";
}
return "";
}
}
|